Fix hybrid tests #1363
Merged
Fix hybrid tests #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jan 3, 2023
gtsam/hybrid/HybridConditional.cpp
Outdated
| @@ -117,6 +117,22 @@ bool HybridConditional::equals(const HybridFactor &other, double tol) const { | |||
| return other != nullptr && dc->equals(*other, tol); | |||
| } | |||
| return inner_->equals(*(e->inner_), tol); | |||
|
|
|||
| if (inner_) { | |||
There was a problem hiding this comment.
Maybe
return inner_ ? (e->inner_ ? inner_->equals(*(e->inner_), tol) : false) : !(e->inner_);
|
I hinted at not needing another CO2 wasting CI run :-) |
True, but I wanted to keep this self-contained... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tests after changes due to #1362.